Add report, bookmark functionality, and UI improvements#50
Conversation
Signed-off-by: Spandan Hota <spandanhota2005@outlook.com>
Signed-off-by: Spandan Hota <spandanhota2005@outlook.com>
Signed-off-by: Spandan Hota <spandanhota2005@outlook.com>
Signed-off-by: Spandan Hota <spandanhota2005@outlook.com>
Signed-off-by: Spandan Hota <spandanhota2005@outlook.com>
Signed-off-by: Spandan Hota <spandanhota2005@outlook.com>
Signed-off-by: Spandan Hota <spandanhota2005@outlook.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces bookmarking and reporting features, including database schema updates, new API endpoints for admin and user actions, and corresponding frontend components. It also improves the authentication flow by redirecting unauthorized domains and adds automated tooltips for accessibility. Feedback was provided regarding the inconsistent use of server-side versus client-side timestamps for database updates and a suggestion to refactor string trimming logic for better readability.
| return reply.status(403).send({ success: false, error: "Forbidden" }); | ||
|
|
||
| const now = new Date().toISOString(); | ||
| const now = sql`now()`; |
There was a problem hiding this comment.
Using sqlnow()for thenowvariable inside a transaction is fine, but it is inconsistent with the use ofnew Date().toISOString()` elsewhere in the same file (e.g., in the draft publish route). It is better to use a consistent approach for timestamps to avoid potential timezone or format discrepancies.
| const res = await api.createThread({ | ||
| topicId: selectedTopicId, | ||
| threadTitle: title, | ||
| content: content.trim(), |
There was a problem hiding this comment.
The content field is being trimmed before being sent to the API. While this is good, the validation logic on line 59 already checks content.trim().length < 1. It would be cleaner to perform the trim once and store it in a variable before validation and API call.
2 participants
This pull request introduces a bookmark system for threads and a post reporting system along with the necessary API endpoints for both users and admins.
Changed the authentication error for non-allowed email domains to redirect to the /login with an error query param.
Minor Frontend changes like improving responsiveness, visiblity and shifting position of buttons
Revamped login page UI